This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(menu): close menu on tab #11127
Merged
fix(menu): close menu on tab #11127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
force-pushed
the
closeMenuOnTab
branch
from
4341e66 to
136956b
Compare
Splaktar
added
a11y
crisbeto
reviewed
Feb 18, 2018
| @@ -289,6 +289,7 @@ function MenuProvider($$interimElementProvider) { | |||
| var handled; | |||
| switch (ev.keyCode) { | |||
| case $mdConstant.KEY_CODE.ESCAPE: | |||
| case $mdConstant.KEY_CODE.TAB: | |||
| opts.mdMenuCtrl.close(false, { closeAll: true }); | |||
| handled = true; | |||
There was a problem hiding this comment.
Looking at the logic below, when an event is marked as handled, it'll prevent the default action. This shouldn't be the case for TAB, because it'll prevent people from moving forward.
Splaktar
force-pushed
the
closeMenuOnTab
branch
from
86c6b45 to
68694c8
Compare
|
Feedback addressed. Ready for presubmit. |
jelbourn
reviewed
Feb 20, 2018
| @@ -292,6 +292,10 @@ function MenuProvider($$interimElementProvider) { | |||
| opts.mdMenuCtrl.close(false, { closeAll: true }); | |||
| handled = true; | |||
| break; | |||
| case $mdConstant.KEY_CODE.TAB: | |||
| opts.mdMenuCtrl.close(false, { closeAll: true }); | |||
| handled = false; | |||
There was a problem hiding this comment.
Add comment that explains why handled = false here.
use only arrow keys to navigate menus resolve issue where tab can escape the panel Fixes #11123
Splaktar
force-pushed
the
closeMenuOnTab
branch
from
68694c8 to
6e64a7b
Compare
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
use only arrow keys to navigate menus resolve issue where tab can escape the panel Fixes angular#11123
Splaktar
added a commit
that referenced
this pull request
Jul 31, 2018
use only arrow keys to navigate menus resolve issue where tab can escape the panel Fixes #11123
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Pressing tab inside of a menu panel (
md-menu-content) can cause the focus to escape the panel and move to other parts of the page (with the menu panel still open).Issue Number:
Fixes #11123
What is the new behavior?
Use only arrow keys to navigate menus (not tabs).
Resolve issue where tab can escape the panel by closing the menu when the
TABkeyCode is detected.Does this PR introduce a breaking change?
Other information
N/A