-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(toast): update style direction to flex-direction #11169
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed the CLA. |
CLAs look good, thanks! |
Yep, looks like only |
Thank you for your contribution! Please update your commit message to follow the commit message guidelines. This is important for your changes to properly show up in the changelog. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message.
This looks good to me once the commit message gets updated. Thank you! |
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text. This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
Commit message is updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text. This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text. This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.
This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The css property "direction" is set to the value of "row" in the md-toast component.
What is the new behavior?
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction" instead of "direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.
This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
Does this PR introduce a breaking change?
Other information