Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(toast): update style direction to flex-direction #11169

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

ypislon
Copy link
Contributor

@ypislon ypislon commented Mar 16, 2018

In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.

This doesn't change the behaviour of md-toast, just cleaning up a small typo :)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The css property "direction" is set to the value of "row" in the md-toast component.

What is the new behavior?

In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction" instead of "direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.

This doesn't change the behaviour of md-toast, just cleaning up a small typo :)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Mar 16, 2018
@ypislon
Copy link
Contributor Author

ypislon commented Mar 16, 2018

I signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Mar 16, 2018
@Splaktar
Copy link
Member

Yep, looks like only rtl and ltr are valid values other than initial/inherit/unset.

@Splaktar
Copy link
Member

Thank you for your contribution! Please update your commit message to follow the commit message guidelines. This is important for your changes to properly show up in the changelog.

For example: fix(toast): update style direction to flex-direction

@Splaktar Splaktar self-assigned this Mar 22, 2018
@Splaktar Splaktar self-requested a review March 22, 2018 08:30
@Splaktar Splaktar added this to the 1.1.9 milestone Mar 22, 2018
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message.

@Splaktar Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs type: bug ui: CSS P5: nice to have These issues will not be fixed without community contributions. labels Mar 22, 2018
@Splaktar
Copy link
Member

This looks good to me once the commit message gets updated. Thank you!

@Splaktar Splaktar changed the title mdToast: remove incorrect css value fix(toast): update style direction to flex-direction Mar 22, 2018
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.

This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
@ypislon
Copy link
Contributor Author

ypislon commented Mar 22, 2018

Commit message is updated!

Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 22, 2018
@andrewseguin andrewseguin merged commit 1ef9ec3 into angular:master Mar 23, 2018
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.

This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
In the component md-toast the property "direction" is set to "row". It seems like it's intended to use "flex-direction", as "row" is not a valid value for the property direction, which should indicate the direction of text.

This doesn't change the behaviour of md-toast, just cleaning up a small typo :)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P5: nice to have These issues will not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants