Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(nav-bar): initial disabled state is now respected #11185

Merged
merged 1 commit into from
Mar 26, 2018
Merged

fix(nav-bar): initial disabled state is now respected #11185

merged 1 commit into from
Mar 26, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The initial value of the disabled attribute is not read or respected. It is only read when it changes via MutationObserver or attrs.$observe.

Issue Number:
Closes #11172. Relates to #10688.

What is the new behavior?

The initial value of the disabled attribute is now read and respected.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

remove issues with tests that hid this bug
improve docs for nav-bar and nav-item
add ng-blur to button docs as its used by nav-item

@Splaktar
fix(nav-bar): initial disabled state is now respected
7767085 
remove issues with tests that hid this bug
improve docs for nav-bar and nav-item
add ng-blur to button docs as its used by nav-item

Closes #11172. Relates to #10688.
@Splaktar Splaktar added type: bug P2: required Issues that must be fixed. labels Mar 23, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Mar 23, 2018
@Splaktar Splaktar requested a review from crisbeto March 23, 2018 08:25
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 23, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Mar 23, 2018
@andrewseguin andrewseguin added the pr: lgtm This PR has been approved by the reviewer label Mar 23, 2018
@andrewseguin andrewseguin merged commit d412358 into master Mar 26, 2018
@Splaktar Splaktar deleted the fixNavBarDisabled branch March 26, 2018 19:09
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
@Splaktar @chmelevskij
fix(nav-bar): initial disabled state is now respected (angular#11185)
35387d9 
remove issues with tests that hid this bug
improve docs for nav-bar and nav-item
add ng-blur to button docs as its used by nav-item

Closes angular#11172. Relates to angular#10688.
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
fix(nav-bar): initial disabled state is now respected (#11185)
69afd7c 
remove issues with tests that hid this bug
improve docs for nav-bar and nav-item
add ng-blur to button docs as its used by nav-item

Closes #11172. Relates to #10688.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@andrewseguin andrewseguin

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.

bug(md-nav-bar): disabled attribute doesn't work as expected
3 participants
@Splaktar @googlebot @andrewseguin