Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(panel): use $event.target instead of $event.srcElement for Firefox compatibility #11234

Merged
merged 1 commit into from
Apr 17, 2018
Merged

fix(panel): use $event.target instead of $event.srcElement for Firefox compatibility #11234

merged 1 commit into from
Apr 17, 2018

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 15, 2018 •
edited by Splaktar
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Panel demos are using $event.srcElement which is not supported by Firefox browsers.

Issue Number: #11035

What is the new behavior?

Panel demos are now using $event.target

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 15, 2018
@Splaktar Splaktar added the needs: review This PR is waiting on review from the team label Apr 17, 2018
@Splaktar Splaktar self-requested a review April 17, 2018 03:43
@Splaktar Splaktar added browser: FireFox type: bug P3: important Important issues that really should be fixed when possible. labels Apr 17, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 17, 2018
Splaktar
Splaktar approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer and removed needs: review This PR is waiting on review from the team labels Apr 17, 2018
@Splaktar
Copy link
Contributor

@feloy great catch! Thank you! It's pretty bad that not only the panel, but also the docs were using a proprietary IE-only API.

@mmalerba mmalerba merged commit c86767f into angular:master Apr 17, 2018
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
@feloy @chmelevskij
fix(panel): use $event.target instead of $event.srcElement for Firefo…
48541a4 
…x compatibility (angular#11234)

Closes angular#11035
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
@feloy @Splaktar
fix(panel): use $event.target instead of $event.srcElement for Firefo…
1b99e66 
…x compatibility (#11234)

Closes #11035
@Splaktar Splaktar mentioned this pull request Dec 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
browser: FireFox cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@feloy @Splaktar @googlebot @mmalerba