This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): align highlight style with spec #11244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is an a11y issue where the difference between highlighted text is too small (unnoticeable to many people without perfect eyesight or high end monitors).
Additionally, the currently highlight styling does not align with the Material Design spec which was changed from lighter text to bold text for highlight in autocomplete/search.
Issue Number:
Fixes #10060
What is the new behavior?
Follow the updated spec by highlighting text in bold, thus making it easier for people with poor monitors or eyesight to differentiate the highlighted text.
Does this PR introduce a breaking change?
Other information
It is likely that this will break some screenshot tests, but it should not break application behavior. The changes increase a11y by making the highlighted text more visible via both contrast and shape changes.