Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): align highlight style with spec #11244

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

There is an a11y issue where the difference between highlighted text is too small (unnoticeable to many people without perfect eyesight or high end monitors).
Additionally, the currently highlight styling does not align with the Material Design spec which was changed from lighter text to bold text for highlight in autocomplete/search.

Issue Number:
Fixes #10060

What is the new behavior?

Follow the updated spec by highlighting text in bold, thus making it easier for people with poor monitors or eyesight to differentiate the highlighted text.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

It is likely that this will break some screenshot tests, but it should not break application behavior. The changes increase a11y by making the highlighted text more visible via both contrast and shape changes.

fix a11y issue where difference between highlighted text is too small

Fixes #10060
@Splaktar Splaktar added type: bug a11y This issue is related to accessibility ui: theme P4: minor Minor issues. May not be fixed without community contributions. type: spec alignment For issues related to aligning with the Material Design Spec labels Apr 19, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 19, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 19, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer labels Apr 19, 2018
@andrewseguin andrewseguin merged commit 011315f into master Apr 23, 2018
@Splaktar Splaktar deleted the autocompleteHighlightSpecAlignment branch April 24, 2018 07:29
Splaktar added a commit that referenced this pull request Jul 31, 2018
fix a11y issue where difference between highlighted text is too small

Fixes #10060
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug type: spec alignment For issues related to aligning with the Material Design Spec ui: theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete: highlight hardly highlights anything
4 participants