This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): don't show the menu panel when readonly #11245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
added
type: bug
a11y
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 19, 2018
| */ | ||
| function shouldHide () { | ||
| if (!isSearchable()) return true; // Hide when not able to query | ||
| else return !shouldShow(); // Hide when the dropdown is not able to show. | ||
| // Hide when not able to run the query. |
There was a problem hiding this comment.
The fact that this isn't just return !this.shouldShow() feels kind of weird to me
There was a problem hiding this comment.
I agree. I've made an update. What do you think?
this could sometimes happen when no value was selected Fixes #11231
Splaktar
force-pushed
the
autocompleteRespectReadonly
branch
from
2d99541 to
7a1d26e
Compare
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
…1245) this could sometimes happen when no value was selected Fixes angular#11231
Splaktar
added a commit
that referenced
this pull request
Jul 31, 2018
this could sometimes happen when no value was selected Fixes #11231
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Autocomplete menu opens and shows options when
readonlyis set totrue. This could sometimes happen when no value was selected.Issue Number:
Fixes #11231
What is the new behavior?
The menu is never shown when
readonlyis set totrue.Does this PR introduce a breaking change?
Other information
N/A