-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(datepicker): calendar panel supports multi theme scenario #11267
fix(datepicker): calendar panel supports multi theme scenario #11267
Conversation
b35a99f
to
5498332
Compare
there is something wrong with .md-datepicker-calendar-pane {
border-color: '{{background-hue-1}}';
} but inside DOM .md-default-theme .md-datepicker-calendar-pane, .md-datepicker-calendar-pane {
border-color: rgb(255,255,255);
} seems like missing current theme name in generated
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rudzikdawid are the issues you mention in #11267 (comment) resolved? or is this still an outstanding question? This doesn't seem to be an issue with your latest changes. |
caretaker note: there are some screendiffs due to slight change in colors, but it looks like they can all be approved |
Closes #11265
example of issue: https://codepen.io/anon/pen/GdrKPp?editors=1010
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
https://codepen.io/anon/pen/GdrKPp?editors=1010
In dynamic multi theme scenario we have light background of
datepicker
in dark theme.This issue only appear in multi theme scenario. With single default dark theme doesn't appear.
Issue Number:
#11265
What is the new behavior?
In multi theme scenario we should have dark background of
datepicker
in dark theme.Does this PR introduce a breaking change?
Other information
before: dark theme in multi theme scenario

after: dark theme in multi theme scenario
