Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

rudzikdawid
Copy link
Contributor

@rudzikdawid rudzikdawid commented Apr 28, 2018

Closes #11265
example of issue: https://codepen.io/anon/pen/GdrKPp?editors=1010

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

https://codepen.io/anon/pen/GdrKPp?editors=1010
In dynamic multi theme scenario we have light background of datepicker in dark theme.
This issue only appear in multi theme scenario. With single default dark theme doesn't appear.

Issue Number:
#11265

What is the new behavior?

In multi theme scenario we should have dark background of datepicker in dark theme.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

before: dark theme in multi theme scenario

after: dark theme in multi theme scenario

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 28, 2018
@rudzikdawid rudzikdawid force-pushed the fixDatepickerPopupMultiTheme branch from b35a99f to 5498332 Compare April 28, 2018 19:42
@rudzikdawid
Copy link
Contributor Author

rudzikdawid commented Apr 28, 2018

there is something wrong with .md-datepicker-calendar-pane element in dynamic dark theme scenario
we have inside datePicker-theme.scss:

  .md-datepicker-calendar-pane {
    border-color: '{{background-hue-1}}';
  }

but inside DOM themeBuildStream() generate:

.md-default-theme .md-datepicker-calendar-pane, .md-datepicker-calendar-pane {
    border-color: rgb(255,255,255);
}

seems like missing current theme name in generated <style>

'{{background-hue-1}}' in others elements are generated to value: rgb(66,66,66) in dynamic dark theme. But from some reason .md-datepicker-calendar-pane has rgb(255,255,255) why?

@Splaktar Splaktar self-requested a review May 15, 2018 01:33
@Splaktar Splaktar added this to the 1.1.10 milestone May 15, 2018
@Splaktar Splaktar added type: bug ui: theme P4: minor Minor issues. May not be fixed without community contributions. needs: manual testing This issue or PR needs to have some manual testing and verification done labels May 15, 2018
@Splaktar Splaktar self-assigned this May 15, 2018
@Splaktar Splaktar added the needs: review This PR is waiting on review from the team label May 15, 2018
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar
Copy link
Contributor

@rudzikdawid are the issues you mention in #11267 (comment) resolved? or is this still an outstanding question? This doesn't seem to be an issue with your latest changes.

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer and removed needs: manual testing This issue or PR needs to have some manual testing and verification done needs: review This PR is waiting on review from the team labels May 23, 2018
@Splaktar Splaktar assigned mmalerba and unassigned Splaktar May 23, 2018
@Splaktar
Copy link
Contributor

Example from my testing:
screen shot 2018-05-23 at 5 21 35 pm

Looks good!

@mmalerba
Copy link
Contributor

caretaker note: there are some screendiffs due to slight change in colors, but it looks like they can all be approved

@mmalerba mmalerba removed their assignment Jun 1, 2018
@jelbourn jelbourn merged commit 9e6553d into angular:master Jun 22, 2018
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-datepicker: panel doesn't inherit dark theme in multi theme scenario
7 participants