Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(navBar): missing [disabled] scss selector #11269

Merged
merged 1 commit into from
May 16, 2018

Conversation

rudzikdawid
Copy link
Contributor

Closes #11268

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

https://material.angularjs.org/HEAD/demo/navBar
color of disabled button._md-nav-button is the same as normal enabled button: button.md-unselected

Issue Number:
#11268

What is the new behavior?

Color of disabled button should have value: '{{foreground-3}}'

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Before:

After:

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 5, 2018
@Splaktar Splaktar added this to the 1.1.10 milestone May 15, 2018
@Splaktar Splaktar self-requested a review May 15, 2018 01:28
@Splaktar Splaktar added type: bug ui: CSS P4: minor Minor issues. May not be fixed without community contributions. labels May 15, 2018
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer labels May 15, 2018
@tinayuangao tinayuangao merged commit d607e17 into angular:master May 16, 2018
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navBar: foreground-3 color for [disabled] selector
4 participants