Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): unwanted re-focus of last chip after blur #11305

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

As described by @caseyjhol, "With md-add-on-blur enabled, clicking outside mdChips or selecting another input element results in the previously focused mdChips being highlighted again. This is especially jarring on a mobile device (e.g. type in some text for the chip, scroll down to the next form element, select it, and then the chip is added but mdChips is then scrolled back into position and focused). It's also not possible to tab to the next element."

Issue Number:
Fixes #10758

What is the new behavior?

this solves a regression introduced in 1.1.2 by #9650
change ng-change demo to use $log instead of alert
fix some lint line length warnings
JSDoc clean up

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added type: bug a11y This issue is related to accessibility ui: focus severity: regression This issue is related to a regression ux: polish P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels May 30, 2018
@Splaktar Splaktar added this to the 1.1.10 milestone May 30, 2018
@Splaktar Splaktar requested a review from devversion May 30, 2018 00:16
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 30, 2018
@Splaktar Splaktar removed the request for review from devversion May 30, 2018 00:17
@Splaktar Splaktar force-pushed the fixChipsRefocusOnBlur branch from 0a049bf to 6eadf16 Compare May 30, 2018 00:25
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jun 4, 2018
this solves a regression introduced in 1.1.2 by #9650
change `ng-change` demo to use `$log` instead of `alert`
fix some lint line length warnings
JSDoc clean up

Fixes #10758
@Splaktar Splaktar force-pushed the fixChipsRefocusOnBlur branch from 6eadf16 to ebd5db1 Compare June 17, 2018 06:21
@jelbourn jelbourn merged commit ae17515 into master Jun 22, 2018
@Splaktar Splaktar deleted the fixChipsRefocusOnBlur branch June 22, 2018 22:08
Splaktar added a commit that referenced this pull request Jul 31, 2018
this solves a regression introduced in 1.1.2 by #9650
change `ng-change` demo to use `$log` instead of `alert`
fix some lint line length warnings
JSDoc clean up

Fixes #10758
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug ui: focus ux: polish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chips: unwanted re-focus of last chip after blur
5 participants