Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 2, 2018

Closes #11312

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If a md-select control has a custom validation on it using $setValidity(false), the required * will show on the chosen value even though the value is populated.

Issue Number: 11312

What is the new behavior?

The required * will show on the value only if no value is chosen. It will still display on placeholder.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 2, 2018
@Splaktar Splaktar self-requested a review July 5, 2018 21:14
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Splaktar Splaktar added this to the 1.1.11 milestone Jul 5, 2018
@Splaktar Splaktar self-assigned this Jul 5, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer type: bug P4: minor Minor issues. May not be fixed without community contributions. labels Jul 5, 2018
@mmalerba mmalerba merged commit f7b7f10 into angular:master Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select(required): asterisk shows on value and label when using custom validations
4 participants