Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): set dirty when a chip is removed #11363

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jul 9, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Removing a chip does not cause the form to be marked dirty.

Issue Number:
Fixes #11356

What is the new behavior?

Forms are marked dirty when a chip is removed.
Added passing tests for $dirty/$pristine when adding and removing chips.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

add tests for $dirty/$pristine when adding and removing chips

Fixes #11356
@Splaktar Splaktar added type: bug pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Jul 9, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Jul 9, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 9, 2018
@jelbourn jelbourn merged commit 0dd688c into master Jul 11, 2018
@Splaktar Splaktar deleted the updateFormStateOnChipRemoval branch July 11, 2018 18:51
Splaktar added a commit that referenced this pull request Jul 31, 2018
add tests for $dirty/$pristine when adding and removing chips

Fixes #11356
Splaktar added a commit that referenced this pull request Aug 2, 2018
add tests for $dirty/$pristine when adding and removing chips

Fixes #11356
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chips: removing a chip is not causing validators to run ($dirty, $pristine not update)
3 participants