This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): give focus to the first option when loaded asynchronously #11372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix a problem with loosing the focus and not allowing the keys to navigate through the options displayed in the dropdown menu. Fixes angular#11357
googlebot
added
the
cla: yes
Splaktar
added
type: bug
a11y
Splaktar
approved these changes
Jul 19, 2018
Splaktar
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a problem with loosing the focus and not allowing
the keys to navigate through the options displayed in the dropdown menu.
Fixes #11357
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
While loading the options asynchronously the focus is on the spinner.
When completed, the spinner is removed together with the focus.
Because of it the arrow keys cause search to be run again rather than allowing navigation within dropdown menu.
Issue Number: #11357
What is the new behavior?
After all the options are loaded the first one is given the focus to allow the navigation
within the dropdown menu to match the behavior of when the options are provided statically.
Does this PR introduce a breaking change?
Other information