This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): md-center-tabs causes in high CPU usage #11375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
pr: merge ready
This was referenced Jul 20, 2018
Splaktar
added a commit
that referenced
this pull request
Jul 31, 2018
<!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [ ] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? `md-center-tabs` causes constant 30-50% CPU usage due to indefinite execution of `updateInkBarStyles()`; <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Fixes #9690. Fixes #6375. ## What is the new behavior? - make updateInkBarStyles() a noop if md-no-ink-bar is set - remove md-no-ink docs as the feature does not exist - clean up md-tab docs - add JSDoc and improve comments in TabsController - add TODOs for min/max widths that no longer match the latest MD spec - update URLs to MD spec ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information
Splaktar
added a commit
that referenced
this pull request
Aug 2, 2018
<!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [ ] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? `md-center-tabs` causes constant 30-50% CPU usage due to indefinite execution of `updateInkBarStyles()`; <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Fixes #9690. Fixes #6375. ## What is the new behavior? - make updateInkBarStyles() a noop if md-no-ink-bar is set - remove md-no-ink docs as the feature does not exist - clean up md-tab docs - add JSDoc and improve comments in TabsController - add TODOs for min/max widths that no longer match the latest MD spec - update URLs to MD spec ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
md-center-tabscauses constant 30-50% CPU usage due to indefinite execution ofupdateInkBarStyles();Issue Number:
Fixes #9690. Fixes #6375.
What is the new behavior?
Does this PR introduce a breaking change?
Other information