Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(list): account for IE11 bug with flexbox and min-height #11393

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

codymikol
Copy link
Contributor

@codymikol codymikol commented Aug 1, 2018

when using an md-3-line list item, use the mixin workaround for ie11 flexbug https://github.com/philipwalton/flexbugs#flexbug-3

Fixes #11177

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently in IE11, md-list-item content vertical alignment can break if the md-list-item has a click event applied to it.

Issue Number: #11177

What is the new behavior?

Now the alignment will be correct in IE11. This is accomplished by wrapping the applied min-height in the ie11-min-height-flexbug mixin.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 1, 2018
@Splaktar Splaktar changed the title fix(list): mind ie11 flexbug for min-hight fix(list): account for IE11 bug with flexbox and min-height Aug 1, 2018
@Splaktar Splaktar self-requested a review August 1, 2018 23:53
@Splaktar Splaktar self-assigned this Aug 1, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Aug 1, 2018
@Splaktar Splaktar added type: bug ui: layout P3: important Important issues that really should be fixed when possible. browser: IE This issue is specific to Internet Explorer ui: CSS labels Aug 1, 2018
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar
Copy link
Member

Splaktar commented Aug 1, 2018

Please update the commit message title to be fix(list): account for IE11 bug with flexbox and min-height.

@Splaktar Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs pr: lgtm This PR has been approved by the reviewer labels Aug 1, 2018
@Splaktar
Copy link
Member

Splaktar commented Aug 1, 2018

Oh and thank you for reporting and fixing this!

when using an md-3-line list item, use the mixin workaround for ie11 flexbug https://github.com/philipwalton/flexbugs#flexbug-3

Fixes angular#11177
@codymikol
Copy link
Contributor Author

Commit title is fixed, thanks for reviewing so quickly 🎉

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Aug 2, 2018
@Splaktar Splaktar assigned jelbourn and josephperrott and unassigned jelbourn Aug 2, 2018
@josephperrott josephperrott merged commit e3c1a5c into angular:master Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS ui: layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list-item: layout alignment breaks in IE 11
5 participants