Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(input): remove placeholder from button accessibility tree #11404

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Aug 11, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Input placeholders appeared in screen reader button accessibility trees as interactive elements due to ng-aria.

Issue Number:
Fixes #11293

What is the new behavior?

Input placeholders no longer appear in screen reader button accessibility trees as interactive elements.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Verified fix in this CodePen

@Splaktar Splaktar added type: bug a11y This issue is related to accessibility browser: Chrome g3: reported The issue was reported by an internal or external product team. P3: important Important issues that really should be fixed when possible. labels Aug 11, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Aug 11, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 11, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Aug 11, 2018
@mmalerba mmalerba merged commit 2203eec into master Aug 14, 2018
@Splaktar Splaktar deleted the buttonRoleOnInputPlaceholder branch August 14, 2018 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility browser: Chrome cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input: ngAria adds role 'button' to placeholder label, confusing screen readers
3 participants