This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(input-container): handle initialization of md-icon with ng-if #11437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
added
type: bug
severity: regression
googlebot
added
the
cla: yes
Splaktar
force-pushed
the
fixIconInputContainerNgIf
branch
from
3d6e515 to
f026e4a
Compare
|
The only Travis failures here are related to an issue with the AngularJS 1.7.4 release/staging. It's unrelated to AngularJS Material. |
nobitagit
pushed a commit
to nobitagit/material
that referenced
this pull request
Sep 24, 2018
…gular#11437) <!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [x] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? If a `md-input-container` has an `md-icon` that has an `ng-if` that resolves to false (the icon should be removed), the `md-icon-left` or `md-icon-right` class is applied to the `md-input-container` incorrectly. This regression was introduced in 1.1.1. <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Fixes angular#9529 Relates to angular#9155 Relates to angular#9151 ## What is the new behavior? If a `md-input-container` has an `md-icon` that has an `ng-if` that resolves to false (the icon should be removed), the `md-icon-left` or `md-icon-right` class won't be applied to the `md-input-container` incorrectly. ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information [This CodePen](https://codepen.io/Splaktar/pen/qMVxZB?editors=1010#0) demonstrates the fix in this PR.
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
…gular#11437) <!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [x] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? If a `md-input-container` has an `md-icon` that has an `ng-if` that resolves to false (the icon should be removed), the `md-icon-left` or `md-icon-right` class is applied to the `md-input-container` incorrectly. This regression was introduced in 1.1.1. <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Fixes angular#9529 Relates to angular#9155 Relates to angular#9151 ## What is the new behavior? If a `md-input-container` has an `md-icon` that has an `ng-if` that resolves to false (the icon should be removed), the `md-icon-left` or `md-icon-right` class won't be applied to the `md-input-container` incorrectly. ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information [This CodePen](https://codepen.io/Splaktar/pen/qMVxZB?editors=1010#0) demonstrates the fix in this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a
md-input-containerhas anmd-iconthat has anng-ifthat resolves to false (the icon should be removed), themd-icon-leftormd-icon-rightclass is applied to themd-input-containerincorrectly.This regression was introduced in 1.1.1.
Issue Number:
Fixes #9529
Relates to #9155
Relates to #9151
What is the new behavior?
If a
md-input-containerhas anmd-iconthat has anng-ifthat resolves to false (the icon should be removed), themd-icon-leftormd-icon-rightclass won't be applied to themd-input-containerincorrectly.Does this PR introduce a breaking change?
Other information
This CodePen demonstrates the fix in this PR.