This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): perform full cleanup of the select drop-down after the c… #11448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lose it affects on the drop-down size if resize is happening after using the select Fixes #11447
googlebot
added
the
cla: yes
Splaktar
added
needs: review
Splaktar
approved these changes
Sep 19, 2018
| 'bottom': '', | ||
| 'left': '', | ||
| 'font-size': '', | ||
| 'min-width': '' |
There was a problem hiding this comment.
Thankfully it looks like it results in these styles being cleared rather than having them set to empty strings.
Splaktar
added
pr: merge ready
|
Thank you very much for your first contribution to AngularJS Material! It looks great to me. We'll send this to run some presubmit tests in Google and then merge it if successful. |
nobitagit
pushed a commit
to nobitagit/material
that referenced
this pull request
Sep 24, 2018
…lose (angular#11448) it affects on the drop-down size if resize is happening after using the select Fixes angular#11447
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
…lose (angular#11448) it affects on the drop-down size if resize is happening after using the select Fixes angular#11447
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(select): perform full cleanup of the select drop-down after the close
it affects on the drop-down size if resize is happening after using the select
Fixes #11447
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
-[ ] CI related changes
What is the current behavior?
Issue Number: #11447What is the new behavior?
Does this PR introduce a breaking change?