Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Using the keyboard to focus on a switch in dark mode shows dark ink on a dark background.

Issue Number:
#8518

What is the new behavior?

Using the keyboard to focus on a switch in dark mode shows light ink on a dark background as defined by the spec.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This builds upon @rudzikdawid's work in #11417.

@Splaktar Splaktar added type: bug ui: theme P4: minor Minor issues. May not be fixed without community contributions. labels Sep 25, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Sep 25, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Sep 25, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Sep 25, 2018
@josephperrott josephperrott added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Oct 17, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@josephperrott
Copy link
Member

Confirmed CLA manually.

@Splaktar Splaktar assigned mmalerba and jelbourn and unassigned josephperrott and mmalerba Oct 23, 2018
@jelbourn jelbourn merged commit 71e0411 into master Nov 6, 2018
@Splaktar Splaktar deleted the fixSwitchFocusTheme branch November 7, 2018 18:36
marosoft pushed a commit to marosoft/material that referenced this pull request Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: bug ui: theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants