fix(virtual-repeat-container): support horizontal scrollbar in vertical orientation

[ghost]

Issue #11461 : md-virtual-repeat-container: Scrolling to lasts elements do not render elements

PR Checklist

Please check that your PR fulfills the following requirements:

• The commit message follows our guidelines
• Tests for the changes have been added or this is not a bug fix / enhancement
• Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #11461

What is the new behavior?

Correct redering of last elements.
CodePen Demo added in issue for testing

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[ghost]

I signed it!

[googlebot]

CLAs look good, thanks!

[codymikol]

I think you might have linked the wrong issue

[ghost]

Thats right, missing the last digit of the number. Corrected ! Thanks

[codymikol]

Looks like the CI failed because of some virtual-repeat tests. I would run the tests locally and make sure you're not breaking any existing functionality and adjust your code / the tests appropriately.

[Splaktar]

You checked the box for "The commit message follows our guidelines" but you didn't follow the guidelines. Please update your commit message and fix any broken unit tests locally.

[Splaktar]

These tests are failing:

Chrome 69.0.3497 (Windows 10.0.0) <md-virtual-repeat> should update topIndex when scrolling FAILED
	Expected -10 to be 0.
	    at UserContext.<anonymous> (src/components/virtualRepeat/virtual-repeater.spec.js:582:28)
Chrome 69.0.3497 (Windows 10.0.0) <md-virtual-repeat> should start at the given topIndex position FAILED
	Expected 0 to be 100.
	    at UserContext.<anonymous> (src/components/virtualRepeat/virtual-repeater.spec.js:604:35)

We'll need all existing tests to pass before we can consider the PR.

[Splaktar]

It would also be helpful if you could explain your approach and add more details for why it handles all of the use cases better than the previous code.

[ghost]

You checked the box for "The commit message follows our guidelines" but you didn't follow the guidelines. Please update your commit message and fix any broken unit tests locally.

Done.

[Splaktar]

@JSitjaNCR I see that you made a commit to the master branch in your fork that added the full PR template markdown to the commit message.

First thing is that when you update a commit or make changes to a PR, you'll need to use your same branch (patch-1 in this case). Then when you commit, you will want to amend the previous commit. Then you need to force push your updates to that same branch.

Second thing, your commit message should look like this:

fix(virtual-repeat-container): support horizontal scrollbar in vertical orientation

programmatic scroll to end causes rendering failures
when horizontal scrollbar is applied

Fixes #11461.

As described in https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format. It doesn't need to include the whole PR template.

Third, the tests are still failing. Please run npm run test:full locally and resolve any test failures, amend your commit, then force push your updates.

[ghost]

First thing is that when you update a commit or make changes to a PR, you'll need to use your same branch (patch-1 in this case). Then when you commit, you will want to amend the previous commit. Then you need to force push your updates to that same branch.

Ok, I'm new on Github. I make my first commit directly into the browser without doing locally a clone, and i don't found the branch to amend the previous commit. (Sorry for my bad english)

Third, the tests are still failing. Please run npm run test:full locally and resolve any test failures, amend your commit, then force push your updates.

Done !

[codymikol]

Make sure to push any changes you made to fix tests 😉

[ghost]

Make sure to push any changes you made to fix tests 😉

Finally found how to clone the branch.
Pushed !
Expect doing the correct thing. 😰

[Splaktar]

No problem with being new to GitHub. We're happy to help you work through it or point you to resources.

I'm glad that you were able to get your fork cloned and push and update to your branch! That's good progress. Once you get the hang of these things, it gets a lot easier and faster 😄

[Splaktar]

Please squash your commits as described at the end of the Submitting Pull Requests section of our Pull Request Guidelines.

You can avoid needing to squash commits in the first place by using Git's amend commit feature. This GitHub Guide on Amending Commits is really helpful.

[Splaktar]

Restarted the one test run that got disconnected. It looks like they will all pass now. Thank you for fixing the tests.

[Splaktar]

LGTM and manual testing was successful.