This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
docs: address Lighthouse audit issues #11475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issues with background contrast remove ng-class expressions which applied unused classes add alt attributes to images add titles to iframes stop disabling user scaling (zooming) Fixes #11452
Splaktar
added
type: docs
a11y
This issue is related to accessibility
P2: required
Issues that must be fixed.
pr: merge ready
This PR is ready for a caretaker to review
pr: merge safe
labels
Oct 4, 2018
googlebot
added
the
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
label
Oct 4, 2018
jelbourn
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Splaktar
added a commit
that referenced
this pull request
Oct 30, 2018
3 tasks
Splaktar
added a commit
that referenced
this pull request
Oct 30, 2018
fix demo a11y issues Relates to #11475
3 tasks
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
fix issues with background contrast remove ng-class expressions which applied unused classes add alt attributes to images add titles to iframes stop disabling user scaling (zooming) Fixes angular#11452
Splaktar
added a commit
that referenced
this pull request
Jun 6, 2019
fix demo a11y issues Relates to #11475
Splaktar
added a commit
that referenced
this pull request
Jun 6, 2019
add special handling for Firefox placeholders add `::placeholder` to the list of pseudos fix demo a11y issues Relates to #11475
Splaktar
added a commit
that referenced
this pull request
Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup` Relates to #11475
3 tasks
Splaktar
added a commit
that referenced
this pull request
Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup` Relates to #11475
Splaktar
added a commit
that referenced
this pull request
Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup` Relates to #11475
mmalerba
pushed a commit
that referenced
this pull request
Jun 17, 2019
use ARIA 1.1 value for `aria-has-popup` Relates to #11475
Splaktar
added a commit
that referenced
this pull request
Jun 25, 2019
add special handling for Firefox placeholders add `::placeholder` to the list of pseudos remove duplicate `::-webkit-input-placeholder` add `::-ms-input-placeholder` for Edge fix demo a11y issues Relates to #11475
mmalerba
pushed a commit
that referenced
this pull request
Aug 14, 2019
add special handling for Firefox placeholders add `::placeholder` to the list of pseudos remove duplicate `::-webkit-input-placeholder` add `::-ms-input-placeholder` for Edge fix demo a11y issues Relates to #11475
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a11y
This issue is related to accessibility
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
P2: required
Issues that must be fixed.
pr: lgtm
This PR has been approved by the reviewer
pr: merge ready
This PR is ready for a caretaker to review
type: docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
86
on the Lighthouse accessibility audit.Issue Number:
Fixes #11452
What is the new behavior?
Does this PR introduce a breaking change?
Other information
New Lighthouse accessibility audit score:
PR #11465 should get us the last 5 points when it is ready.