Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

docs: address Lighthouse audit issues #11475

Merged
merged 1 commit into from Oct 4, 2018
Merged

docs: address Lighthouse audit issues #11475

merged 1 commit into from Oct 4, 2018

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Oct 4, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

86 on the Lighthouse accessibility audit.

Issue Number:
Fixes #11452

What is the new behavior?

  • fix issues with background contrast
  • remove ng-class expressions which applied unused classes
  • add alt attributes to images
  • add titles to iframes
  • stop disabling user scaling (zooming)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

New Lighthouse accessibility audit score:
screen shot 2018-10-04 at 5 25 02 pm

PR #11465 should get us the last 5 points when it is ready.

fix issues with background contrast
remove ng-class expressions which applied unused classes
add alt attributes to images
add titles to iframes
stop disabling user scaling (zooming)

Fixes #11452
@Splaktar Splaktar added this to the 1.1.11 milestone Oct 4, 2018
@Splaktar Splaktar added type: docs a11y This issue is related to accessibility P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Oct 4, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Oct 4, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Oct 4, 2018
@jelbourn jelbourn merged commit 9be3821 into master Oct 4, 2018
@Splaktar Splaktar deleted the fixDocsA11y branch October 4, 2018 23:06
Splaktar added a commit that referenced this pull request Oct 30, 2018
Splaktar added a commit that referenced this pull request Oct 30, 2018
marosoft pushed a commit to marosoft/material that referenced this pull request Nov 11, 2018
fix issues with background contrast
remove ng-class expressions which applied unused classes
add alt attributes to images
add titles to iframes
stop disabling user scaling (zooming)

Fixes angular#11452
Splaktar added a commit that referenced this pull request Jun 6, 2019
Splaktar added a commit that referenced this pull request Jun 6, 2019
add special handling for Firefox placeholders
add `::placeholder` to the list of pseudos
fix demo a11y issues

Relates to #11475
Splaktar added a commit that referenced this pull request Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup`

Relates to #11475
Splaktar added a commit that referenced this pull request Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup`

Relates to #11475
Splaktar added a commit that referenced this pull request Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup`

Relates to #11475
mmalerba pushed a commit that referenced this pull request Jun 17, 2019
use ARIA 1.1 value for `aria-has-popup`

Relates to #11475
Splaktar added a commit that referenced this pull request Jun 25, 2019
add special handling for Firefox placeholders
add `::placeholder` to the list of pseudos
remove duplicate `::-webkit-input-placeholder`
add `::-ms-input-placeholder` for Edge
fix demo a11y issues

Relates to #11475
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
add special handling for Firefox placeholders
add `::placeholder` to the list of pseudos
remove duplicate `::-webkit-input-placeholder`
add `::-ms-input-placeholder` for Edge
fix demo a11y issues

Relates to #11475
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: site contains aria and a11y issues
3 participants