This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(nav-bar): set ng-href on nav-item even if md-nav-href is empty #11488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
added
type: bug
type: chore
P1: urgent
googlebot
added
the
cla: yes
3 tasks
3 tasks
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
…ngular#11488) <!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [x] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? - A new `npm i` may pick up `jasmine-core@2.99.1` which will cause many test failures since we don't currently support that version. - Setting `md-nav-href=""` on an `md-nav-item` doesn't apply the proper `ng-href=""` because of a bad `if` check. - The docs indicate that a navigation attribute **must** be defined on each `md-nav-item`, but the code doesn't throw an exception if this occurs. This can lead to unexpected behaviors like infinite loops or hanging async tasks. - The Closure properties are incorrect in a number of cases. <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Relates to angular#11485. Relates to angular#11486. Fixes angular#11487. ## What is the new behavior? - set ng-href on nav-item even if md-nav-href is empty - fix closure properties to better represent the existing code - pin the version of jasmine-core since we don't support 2.99.1 yet - slightly improve the tone of the exceptions - pull in some karma configuration tweaks from Angular Material ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
npm imay pick upjasmine-core@2.99.1which will cause many test failures since we don't currently support that version.md-nav-href=""on anmd-nav-itemdoesn't apply the properng-href=""because of a badifcheck.md-nav-item, but the code doesn't throw an exception if this occurs. This can lead to unexpected behaviors like infinite loops or hanging async tasks.Issue Number:
Relates to #11485. Relates to #11486. Fixes #11487.
What is the new behavior?
Does this PR introduce a breaking change?
Other information