This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(theme): prepend # to hex codes enableBrowserColor #11492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I am able to get all tests to pass on my local machine Googling the error code on the Travis tests suggests that it is something to do with Karma1.6, but I'm still unsure. Please let me know if there's something I need to change. edit: squashed my commits and the version1.6 tests now succeeds but the 1.7 fails due to timeout. Would this be a fluke? |
check for leading # and prepend update enableBrowserColor tests Fixes angular#11259
|
I've restarted the tests, but we are waiting on PR #11488 to get merged which should help fix some test issues on |
Splaktar
added
ui: theme
type: bug
needs: review
Splaktar
added
pr: merge ready
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
check for leading # and prepend update enableBrowserColor tests Fixes angular#11259
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: fixes #11259
enableBrowserColorfails silently if a hex code does not have a#at the start.What is the new behavior?
enableBrowserColornow checks for a leading#and prepends it if not already there.Does this PR introduce a breaking change?
Other information
I updated other test plans to expect the leading
#, thetestPalettein the test plans did not have a#in their hex values. Originally I tried updating the palette to have a#, but couldn't figure out how to test it without creating another palette, so I went with this way.