fix(theme): prepend # to hex codes enableBrowserColor

[jagmeetb]

PR Checklist

Please check that your PR fulfills the following requirements:

• The commit message follows our guidelines
• Tests for the changes have been added or this is not a bug fix / enhancement
• Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes #11259

enableBrowserColor fails silently if a hex code does not have a # at the start.

What is the new behavior?

enableBrowserColor now checks for a leading # and prepends it if not already there.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

I updated other test plans to expect the leading #, the testPalette in the test plans did not have a # in their hex values. Originally I tried updating the palette to have a #, but couldn't figure out how to test it without creating another palette, so I went with this way.

[jagmeetb]

I am able to get all tests to pass on my local machine

Chrome 70.0.3538 (Windows 7.0.0): Executed 2884 of 2885 (skipped 1) SUCCESS (43.351 secs / 42.579 secs)
Firefox 62.0.0 (Windows 7.0.0): Executed 2884 of 2885 (skipped 1) SUCCESS (1 min 15.55 secs / 1 min 11.396 secs)

Googling the error code on the Travis tests suggests that it is something to do with Karma1.6, but I'm still unsure.

Please let me know if there's something I need to change.

edit: squashed my commits and the version1.6 tests now succeeds but the 1.7 fails due to timeout. Would this be a fluke?

[Splaktar]

I've restarted the tests, but we are waiting on PR #11488 to get merged which should help fix some test issues on master.

[Splaktar]

LGTM