This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): floating label text fails a11y contrast audit #11497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
force-pushed
the
inputFloatingLabelContrast
branch
from
f15abee to
e05a465
Compare
Splaktar
added
type: bug
P3: important
3 tasks
Splaktar
assigned
jelbourn,
andrewseguin and
vivian-hu-zz and unassigned
mmalerba,
jelbourn and
andrewseguin
Splaktar
assigned
jelbourn and
josephperrott and unassigned
mmalerba,
jelbourn and
josephperrott
Splaktar
added
the
in progress
Splaktar
force-pushed
the
inputFloatingLabelContrast
branch
2 times, most recently
from
f9a422a to
c96d214
Compare
Splaktar
added
pr: merge ready
|
Firefox issue solved. Thanks for the heads up @bersLucas! |
add special handling for Firefox placeholders add `::placeholder` to the list of pseudos remove duplicate `::-webkit-input-placeholder` add `::-ms-input-placeholder` for Edge fix demo a11y issues Relates to #11475
Splaktar
force-pushed
the
inputFloatingLabelContrast
branch
from
c96d214 to
862a39d
Compare
This was referenced Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Floating labels use
color: rgba(0,0,0,0.38);which doesn't align with the spec and fails Lighthouse contrast audits. This is the color we use for "disabled" text, which isn't right.Currently our Input demo page gets a Lighthouse score of
77.Issue Number:
Relates to #11475
What is the new behavior?
Floating labels use
rgba(0, 0, 0, 0.54);which passes Lighthouse contrast audits. This is the color we use for "secondary" text, which seems appropriate. We use the fullrgba(0, 0, 0, 0.87);for the primary text (input value).With these changes our Input demo page gets a Lighthouse score of
92.Does this PR introduce a breaking change?
Other information
This is expected to break screenshot tests.
This gets us a step closer to getting 100 in the Lighthouse a11y audit.
Other related issues are