Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(input): placeholder and datepicker value displayed overlapping #11538

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Dec 9, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

css to hide the value doesn't work on Firefox and IE11
this is due to combining webkit pseudo selectors with the general rule

Issue Number:
Fixes #10440

What is the new behavior?

Split out the webkit specific rules from the general rules.
Datepicker inputs no longer overlap the placeholder and value.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

css to hide the value doesn't work on Firefox and IE11
this is due to combining webkit pseudo selectors with the general rule

Fixes #10440
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 9, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Dec 9, 2018
@Splaktar Splaktar added type: bug browser: IE This issue is specific to Internet Explorer browser: FireFox ui: CSS ux: integration P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review labels Dec 9, 2018
@jelbourn jelbourn merged commit 44a6946 into master Dec 20, 2018
@Splaktar Splaktar deleted the input-fixDatePlaceholderOverlap branch December 20, 2018 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: FireFox browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS ux: integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker: case where date and placeholder overlap in IE and FF
5 participants