Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Dec 9, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If the secondary actions' template was provided by a directive, then the actions would be behind the primary button. This meant that tooltips and clicks were not activated.

Issue Number:
Fixes #9676

What is the new behavior?

Secondary action tooltips and clicks are activated when the template is provided by a directive.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

#9676 proposed adding a z-index to the md-secondary-container, but the container did not have a position. By the spec, z-index should only be on "positioned" elements. Adding positioning resolved the issue w/o needing to define a z-index.

if the secondary actions' template was provided by directive
  it the actions would be behind the primary button
  this meant that tooltips and clicks were not activated

Fixes #9676
@Splaktar Splaktar added this to the 1.1.12 milestone Dec 9, 2018
@Splaktar Splaktar self-assigned this Dec 9, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 9, 2018
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. type: bug ui: CSS ux: integration pr: merge ready This PR is ready for a caretaker to review labels Dec 9, 2018
@Splaktar Splaktar assigned jelbourn and mmalerba and unassigned jelbourn Dec 20, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
@mmalerba mmalerba merged commit 708fff9 into master Jan 7, 2019
@Splaktar Splaktar deleted the list-secondaryActionDirectives branch January 7, 2019 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS ux: integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list: z-index preventing function execution on directive inside md-list-item
4 participants