Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(progress-circular): show correct circle arc #11580

Merged
merged 1 commit into from
Mar 6, 2019
Merged

fix(progress-circular): show correct circle arc #11580

merged 1 commit into from
Mar 6, 2019

Conversation

marosoft
Copy link
Contributor

@marosoft marosoft commented Jan 7, 2019 •
edited by Splaktar
Loading

show correct circle arc when changing from in determinate to determinate mode

Fix the broken behavior with the circle arc

Fixes: #11334

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

A wrong circle arc is shown when changing from indeterminate to determinate mode.
Issue Number: #11334

What is the new behavior?

A proper circle arc is shown when changing between different modes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@marosoft
fix(progress-circular): show correct circle arc when changing from in…
75b21e1 
…determinate to determinate mode

Fix the broken behavior with the circle arc

Fixes: angular#11334
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 7, 2019
@Splaktar Splaktar self-assigned this Jan 8, 2019
@Splaktar Splaktar self-requested a review January 8, 2019 22:19
@Splaktar Splaktar changed the title fix(progress-circular): show correct circle arc when changing from in… fix(progress-circular): show correct circle arc Jan 8, 2019
@Splaktar Splaktar added the P4: minor Minor issues. May not be fixed without community contributions. label Jan 22, 2019
Splaktar
Splaktar approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Splaktar Splaktar added this to the 1.1.13 milestone Jan 22, 2019
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer labels Jan 22, 2019
@Splaktar Splaktar modified the milestones: 1.1.13, 1.1.14 Feb 13, 2019
@Splaktar Splaktar assigned andrewseguin and unassigned jelbourn Feb 26, 2019
@josephperrott josephperrott merged commit 686b365 into angular:master Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Splaktar Splaktar

@josephperrott josephperrott

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.1.14
Development

Successfully merging this pull request may close these issues.

progress-circular: wrong circle arc when changing from indeterminate to determinate mode
7 participants
@marosoft @Splaktar @jelbourn @googlebot @josephperrott @mmalerba @andrewseguin