Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(nav-bar): improve focus behavior for click events #11600

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jan 21, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Clicking on nav items with a mouse causes the focus to move to the previously clicked nav item instead of the newly clicked nav item.

Issue Number:
Fixes #11591. Relates to #11494. Closes #11598.

What is the new behavior?

  • Focus is moved to the new nav item after it is clicked.
  • remove hover style that is inconsistent with spec
  • add test from @codymikol

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thank you to @codymikol for doing the initial investigation into this regression!

@Splaktar Splaktar added type: bug severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Jan 21, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Jan 21, 2019
@Splaktar Splaktar self-assigned this Jan 21, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 21, 2019
remove hover style that is inconsistent with spec

Fixes #11591. Relates to #11494. Closes #11598.
@Splaktar Splaktar force-pushed the navBar-fixFocusOnClick branch from 982bd04 to 86aeb74 Compare January 22, 2019 00:21
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jan 22, 2019
@codymikol
Copy link
Contributor

Yeah this seems to be a much better approach 🐔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nav-bar: clicking a tab causes focus to move to a previously selected tab
5 participants