Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(slider): aria attrs are not announced when tabbing in screen readers #11688

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Mar 21, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

aria attributes are not announced when tabbing in screen readers

Issue Number:
Fixes #11685

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

revert changes from #10731
move a number of aria attributes from md-slider to md-slider-wrapper
fix inconsistencies, typos, and mistakes in the demos

Fixes #11685
@Splaktar Splaktar added this to the 1.1.15 milestone Mar 21, 2019
@Splaktar Splaktar self-assigned this Mar 21, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 21, 2019
@Splaktar Splaktar added a11y This issue is related to accessibility P2: required Issues that must be fixed. g3: sync severity: regression This issue is related to a regression type: bug in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 21, 2019
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 21, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 459c03c into master Mar 28, 2019
@Splaktar Splaktar assigned jelbourn and unassigned andrewseguin Mar 29, 2019
@Splaktar Splaktar deleted the slider-fixScreenReaders branch March 29, 2019 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slider: Jaws does not read anything when focus goes on slider
4 participants