Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented May 9, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

A regression in Chromium has caused date and time pickers around the Internet to instantly close when opened via a focus event due to a change in the timing of events. md-datepicker works better than most after going to the 100ms delay to fix Firefox, but it isn't always enough, especially when changing focus from one input to another.

Issue Number:
Fixes #11701

What is the new behavior?

Improve event handling based on suggestions by Navid Zolghadr.

  • Timeouts are eliminated.
  • stopPropagation() on click events from the input
  • In Chrome use the setPointerCapture API to avoid auto closing on pointerdown events

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Related Chromium regression: https://bugs.chromium.org/p/chromium/issues/detail?id=941910

@Splaktar Splaktar added this to the 1.1.19 milestone May 9, 2019
@Splaktar Splaktar self-assigned this May 9, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 9, 2019
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label May 9, 2019
@Splaktar Splaktar removed the pr: merge ready This PR is ready for a caretaker to review label May 9, 2019
@Splaktar Splaktar assigned andrewseguin and unassigned andrewseguin May 9, 2019
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed pr: merge ready This PR is ready for a caretaker to review labels May 9, 2019
@Splaktar Splaktar added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label May 9, 2019
@Splaktar Splaktar force-pushed the datepicker-fixOpenOnFocus branch from 45ea30b to d050f3e Compare May 9, 2019 23:58
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels May 9, 2019
improve event handling based on suggestions by Navid Zolghadr

Fixes #11701
@Splaktar Splaktar force-pushed the datepicker-fixOpenOnFocus branch from d050f3e to df8f21b Compare May 10, 2019 14:07
@mmalerba mmalerba merged commit 73c424d into master May 20, 2019
@Splaktar Splaktar deleted the datepicker-fixOpenOnFocus branch May 20, 2019 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: Chrome cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker: automatically closes/doesn't open after updating to Chrome 73
4 participants