Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jun 6, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • Lighthouse complains due to the datepicker's input having aria-expanded="false". This properly isn't valid for role="input" in ARIA 1.0 or ARIA 1.1.
  • aria-haspopup="true" uses the ARIA 1.0 value.

Issue Number:
Relates to #11475

What is the new behavior?

  • remove invalid aria-expanded attribute
  • use ARIA 1.1 value for aria-has-popup

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

a11y and keyboard interaction with the md-datepicker and the calendar panel is not good, but testing in VoiceOver showed that these changes didn't make it any worse.

@Splaktar Splaktar added type: bug a11y This issue is related to accessibility P4: minor Minor issues. May not be fixed without community contributions. labels Jun 6, 2019
@Splaktar Splaktar added this to the 1.1.20 milestone Jun 6, 2019
@Splaktar Splaktar self-assigned this Jun 6, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 6, 2019
@Splaktar Splaktar force-pushed the datepicker-improveA11y branch from 232d9ef to 70585d3 Compare June 6, 2019 05:48
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jun 6, 2019
use ARIA 1.1 value for `aria-has-popup`

Relates to #11475
@Splaktar Splaktar force-pushed the datepicker-improveA11y branch from 70585d3 to be4c3b5 Compare June 6, 2019 06:52
@Splaktar Splaktar assigned mmalerba and unassigned josephperrott Jun 13, 2019
@mmalerba mmalerba merged commit 197d197 into master Jun 17, 2019
@Splaktar Splaktar deleted the datepicker-improveA11y branch June 17, 2019 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants