This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker): remove invalid aria-expanded #11740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
input
havingaria-expanded="false"
. This properly isn't valid forrole="input"
in ARIA 1.0 or ARIA 1.1.aria-haspopup="true"
uses the ARIA 1.0 value.Issue Number:
Relates to #11475
What is the new behavior?
aria-expanded
attributearia-has-popup
Does this PR introduce a breaking change?
Other information
a11y and keyboard interaction with the
md-datepicker
and the calendar panel is not good, but testing in VoiceOver showed that these changes didn't make it any worse.