This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(toast): toast defaults to wrong values when passed an empty position #11843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
From https://material.angularjs.org/latest/api/service/$mdToast#mdtoast-show-optionsorpreset:
I managed to fix the example by not passing |
Splaktar
added
the
in progress
Splaktar
changed the title
Splaktar
suggested changes
Feb 1, 2020
|
Good point. I will submit an updated version next week. |
|
Sounds good. |
If no position was provided for whatever reason, the default behavior should be to open from the bottom.
|
@Splaktar Sorry for the delay. It should be better now. |
Splaktar
added a commit
that referenced
this pull request
May 5, 2020
- position of "" uses document default positioning - "bottom left" - position of "left" or "right" uses default vertical positioning: "bottom" - improve JSDoc Closes #11843
3 tasks
Splaktar
added a commit
that referenced
this pull request
May 5, 2020
- position of "" uses documented default positioning - "bottom left" - position of "left" or "right" uses default vertical positioning: "bottom" - improve JSDoc Closes #11843
|
I tested this updated fix and it doesn't appear to work. After some investigation, I discovered that there was actually a different place in the code that needed to change. I've opened PR #11904 to solve this. |
Splaktar
added a commit
that referenced
this pull request
Jun 29, 2020
- position of "" uses documented default positioning - "bottom left" - position of "left" or "right" uses default vertical positioning: "bottom" - improve JSDoc Closes #11843. BREAKING CHANGE: $mdToast.show()'s position behavior has been updated to be consistent with the documentation. If you relied on the previously undocumented behavior where it defaulted to `top left` instead of `bottom left`, you will need to update your app. Change your code from this: ```js $mdToast.show( $mdToast.simple() .textContent('Simple Toast!')) .then(... ``` To this: ```js $mdToast.show( $mdToast.simple() .textContent('Simple Toast!') .position('top left')) .then(... ```
Splaktar
added a commit
that referenced
this pull request
Jun 29, 2020
- position of "" uses documented default positioning - "bottom left" - position of "left" or "right" uses default vertical positioning: "bottom" - improve JSDoc Closes #11843. BREAKING CHANGE: `$mdToast.show()`'s position behavior has been updated to be consistent with the documentation. If you relied on the previously undocumented behavior where it defaulted to `top left` instead of `bottom left`, you will need to update your app. Change your code from this: ```js $mdToast.show( $mdToast.simple() .textContent('Simple Toast!')) .then(... ``` To this: ```js $mdToast.show( $mdToast.simple() .textContent('Simple Toast!') .position('top left')) .then(... ```
Splaktar
added a commit
that referenced
this pull request
Jun 29, 2020
- position of "" uses documented default positioning - "bottom left" - position of "left" or "right" uses default vertical positioning: "bottom" - improve JSDoc Closes #11843. BREAKING CHANGE: `$mdToast.show()`'s position behavior has been updated to be consistent with the documentation. If you relied on the previously undocumented behavior where it defaulted to `top left` instead of `bottom left`, you will need to update your app. Change your code from this: ```js $mdToast.show( $mdToast.simple() .textContent('Simple Toast!')) .then(... ``` To this: ```js $mdToast.show( $mdToast.simple() .textContent('Simple Toast!') .position('top left')) .then(... ```
Splaktar
added
resolution: fixed
P3: important
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user specifies no position at all, the toast will open from the top, while the class name will reflect a toast opening from the bottom.
By chaning the ternary as suggested, we end up with the correct default case while maintaining all configured cases as-is.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Go to https://material.angularjs.org/latest/demo/toast and uncheck all 4 checkboxes, then trigger a toast. The toast will appear on the top, the bottom FAB will make space for the toast.
What is the new behavior?
The toast will appear on the top, the top FAB will make space for the toast.
Does this PR introduce a breaking change?