-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(select): sanitize user input before searching options #11855
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
8ab8ae3
to
c2651e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making your first PR to AngularJS Material! 💛
As mentioned below, I'd like to avoid adding duplicate code. So I'd like to add this capability to $mdUtil
and then both components that need it can make use of the same function.
- Please add a blank line and then "Fixes #11854" to your commit message. It's best to amend your commit and force push your branch after your updates are completed.
- Please add a basic unit test for this. It should throw the same error prior to this fix and then work as expected with this fix in place.
c2651e8
to
98c0424
Compare
@Splaktar I applied the requested changes. Thanks for the review. |
98c0424
to
673aace
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the requested updates. LGTM other than it needing to be rebased.
✅ Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number:
#11854
Does this PR introduce a breaking change?