This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
mdIcon: Add support for symbol-tags #1514
Comments
This will actually be made obsolete by #1548, which is scheduled for 1.0.0-beta. Maybe we can close this one? |
I'd love to see this change land in master, such that I / others can already start using |
@programmist - if we are doing another enchancement for Icons in 1.0beta and this will be resolved by those, then let's wait. |
ThomasBurleson
added
the
needs: review
This PR is waiting on review from the team
label
Jul 31, 2015
3 tasks
cobisimo
added a commit
to cobisimo/material
that referenced
this issue
Mar 30, 2018
Add support for SVG icon sets with symbol elements. SVG icon sprite with symbols is most commonly produced by: svg-sprite-loader, webpack-svgstore-plugin, gulp-svg-sprites ... This may consider also as backport, as angular material2 project support this kind of sets. This change is related to angular#8689 issue and directly related to closed issue angular#1514
cobisimo
added a commit
to cobisimo/material
that referenced
this issue
Apr 10, 2018
Add support for SVG icon sets with symbol elements. SVG icon sprite with symbols is most commonly produced by: svg-sprite-loader, webpack-svgstore-plugin, gulp-svg-sprites ... This may consider also as backport, as angular material2 project support this kind of sets. This change is related to angular#8689 issue and directly related to closed issue angular#1514
mmalerba
pushed a commit
that referenced
this issue
Apr 17, 2018
Add support for SVG icon sets with symbol elements. SVG icon sprite with symbols is most commonly produced by: svg-sprite-loader, webpack-svgstore-plugin, gulp-svg-sprites ... This may consider also as backport, as angular material2 project support this kind of sets. This change is related to #8689 issue and directly related to closed issue #1514
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this issue
Jun 19, 2018
Add support for SVG icon sets with symbol elements. SVG icon sprite with symbols is most commonly produced by: svg-sprite-loader, webpack-svgstore-plugin, gulp-svg-sprites ... This may consider also as backport, as angular material2 project support this kind of sets. This change is related to angular#8689 issue and directly related to closed issue angular#1514
Splaktar
pushed a commit
that referenced
this issue
Jul 31, 2018
Add support for SVG icon sets with symbol elements. SVG icon sprite with symbols is most commonly produced by: svg-sprite-loader, webpack-svgstore-plugin, gulp-svg-sprites ... This may consider also as backport, as angular material2 project support this kind of sets. This change is related to #8689 issue and directly related to closed issue #1514
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current implementation of
md-icon
(v0.8.0-rc1-master-91053dc) does not properly handle icons wrapped insymbol
-tags. It just adds the completesymbol
tag:Since
symbol
tags are graphical template objects, they do not show unless they are instantiated by ause
-tag.Use case: the grunt-svgstore plugin merges multiple SVG's into a single SVG (see also this css-tricks post). The plugin wraps each SVG in its own
symbol
tag.Possible solution: include the child nodes instead of the parent
symbol
tag. E.g.:The text was updated successfully, but these errors were encountered: