This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(docs): use correct link to file on github #2900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using source allows us to use the fileInfo to determine the path of the component/service being documented.
Refactored some duplication. Removed the existing github url, which assumed that the path to the file was the same as the module name.
matthewrfindley
force-pushed
the
bug-fix/github-path-to-file
branch
from
41f1a15 to
847d746
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2005
Previously the github url was generated using a convention that most, if not all, components/core services were not adhering to.
Instead of using the consolidated js files in angular-material.js, using the source provides ngDoc with the correct location of the file being documented.