This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(docs): version selection #2916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide when an error occurs
No path was defined causing browsers to look at the root. With the upcoming change to host on firebase, we need to define the location to serve from the relative directory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #918
Version selection is hidden when no docs.json is present. Developing locally will not show the version selector.
This PR is dependant on the new hosting solution proposed by work @robertmesserle has been working on. This can be merged prior to the new hosting solution. The version selection will be hidden until the host can provide the docs.json required to define the versions in the selector.