Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 18, 2015

  • By default - chips are writable and deletable
  • readonly="true"- chips are readonly and not deletable
  • readonly="true" md-removable="true" - chips are readonly, and deletable
  • readonly="true" md-removable="false" - chips are readonly, not deletable
  • md-removable="false"- chips are writable, not deletable

Closes #5796. Fixes #3820.

@ThomasBurleson ThomasBurleson added needs: review This PR is waiting on review from the team and removed needs: review This PR is waiting on review from the team labels Nov 24, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 1.0-rc7 Nov 24, 2015
@devversion devversion force-pushed the feat/chips-removeonly branch from 27828b5 to 804dbc2 Compare November 24, 2015 18:41
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc7, 1.01 Nov 26, 2015
@topherfangio
Copy link
Contributor

I think I would rather see this as an md-removable option that works in tandem with the readonly option.

For instance:

  • By default - chips are writable and deletable (current functionality)
  • readonly="true" - chips are readonly and deletable (current functionality)
  • readonly="true" md-removable="true" - chips are readonly, and deletable (new syntax, but same functionality as above)
  • readonly="true" md-removable="false" - chips are readonly, not deletable (new)
  • md-removable="false" - chips are writable, not deletable (new)

I think this gives the user a bit more customizability and follows better conventions.

Note: In this case, we should begin the attribute with md-. The readonly attribute doesn't contain an md- because it is an existing/standard HTML attribute.

Thoughts?

@topherfangio topherfangio added needs: team discussion This issue requires a decision from the team before moving forward. and removed needs: review This PR is waiting on review from the team labels Dec 30, 2015
@topherfangio topherfangio modified the milestones: 1.1.0, 1.01 Dec 30, 2015
@devversion
Copy link
Member Author

Yes, sorry for the late answer - Seems to be better, I will try to implement that ;)

@devversion devversion force-pushed the feat/chips-removeonly branch 2 times, most recently from 774484f to e1009d7 Compare January 9, 2016 14:26
@devversion
Copy link
Member Author

@topherfangio - All done - Added Tests and added a demo checkbox to toggle the chips ;)

@devversion devversion changed the title feat(chips): add chips feature to allow remove only feat(chips): add tandem functionality removeable with readonly Jan 13, 2016
@ThomasBurleson ThomasBurleson added the P5: nice to have These issues will not be fixed without community contributions. label Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, Backlog Jan 15, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.5 milestone Feb 4, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 1.1.1 Apr 21, 2016
@joaovieira
Copy link

Waiting for this 😭

@topherfangio
Copy link
Contributor

@devversion I know this says "needs: review" but is it actually ready? The comment above leads me to believe that there is more work that needs to be done.

@alice-kroch
Copy link

Really need this feature

@topherfangio
Copy link
Contributor

topherfangio commented May 20, 2016

@ThomasBurleson LGTM! Recommend this for 1.2.0.

- By default - chips are writable **and** deletable
- `readonly="true"`- chips are readonly and not deletable
- `readonly="true" md-removable="true"` - chips are readonly, and deletable
- `readonly="true" md-removable="false"` - chips are readonly, not deletable
- `md-removable="false"`- chips are writable, not deletable

Closes angular#5796. Fixes angular#3820.
@devversion devversion force-pushed the feat/chips-removeonly branch from 5c66642 to bf7eb74 Compare June 3, 2016 15:57
@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Jun 20, 2016
toshiakiezaki pushed a commit to toshiakiezaki/angular-material that referenced this pull request Jul 1, 2016
- By default - chips are writable **and** deletable
- `readonly="true"`- chips are readonly and not deletable
- `readonly="true" md-removable="true"` - chips are readonly, and deletable
- `readonly="true" md-removable="false"` - chips are readonly, not deletable
- `md-removable="false"`- chips are writable, not deletable

Closes angular#5796. Fixes angular#3820.

Closes angular#5799
@devversion devversion deleted the feat/chips-removeonly branch September 15, 2016 18:05
@SneakyTurtle20
Copy link

Any update on this feature? Thanks.

@Splaktar
Copy link
Contributor

Splaktar commented Dec 4, 2020

@SneakyTurtle20 as the PR says, this was released in 1.1.0. You can see a demo of it here: https://material.angularjs.org/latest/demo/chips#basic-usage. There is a checkbox for "Removable".

@angular angular locked as resolved and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Lots of Comments pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chips: allow disable text input Maybe add md-chips read-and-delete-only ?
7 participants