-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(chips): add functionality to disable removing. #5799
Conversation
27828b5
to
804dbc2
Compare
I think I would rather see this as an For instance:
I think this gives the user a bit more customizability and follows better conventions. Note: In this case, we should begin the attribute with Thoughts? |
Yes, sorry for the late answer - Seems to be better, I will try to implement that ;) |
774484f
to
e1009d7
Compare
@topherfangio - All done - Added Tests and added a demo checkbox to toggle the chips ;) |
removeable
with readonly
Waiting for this 😭 |
@devversion I know this says "needs: review" but is it actually ready? The comment above leads me to believe that there is more work that needs to be done. |
Really need this feature |
@ThomasBurleson LGTM! Recommend this for 1.2.0. |
- By default - chips are writable **and** deletable - `readonly="true"`- chips are readonly and not deletable - `readonly="true" md-removable="true"` - chips are readonly, and deletable - `readonly="true" md-removable="false"` - chips are readonly, not deletable - `md-removable="false"`- chips are writable, not deletable Closes angular#5796. Fixes angular#3820.
5c66642
to
bf7eb74
Compare
- By default - chips are writable **and** deletable - `readonly="true"`- chips are readonly and not deletable - `readonly="true" md-removable="true"` - chips are readonly, and deletable - `readonly="true" md-removable="false"` - chips are readonly, not deletable - `md-removable="false"`- chips are writable, not deletable Closes angular#5796. Fixes angular#3820. Closes angular#5799
Any update on this feature? Thanks. |
@SneakyTurtle20 as the PR says, this was released in 1.1.0. You can see a demo of it here: https://material.angularjs.org/latest/demo/chips#basic-usage. There is a checkbox for "Removable". |
readonly="true"
- chips are readonly and not deletablereadonly="true" md-removable="true"
- chips are readonly, and deletablereadonly="true" md-removable="false"
- chips are readonly, not deletablemd-removable="false"
- chips are writable, not deletableCloses #5796. Fixes #3820.