This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): disable scroll events for autocomplete wrap layer #6589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/autocomplete-wrap-scroll-zindex
branch
from
9e29b26 to
ca43e53
Compare
This was referenced Jan 7, 2016
|
nice, it works, resolved my issue #6585 |
devversion
force-pushed
the
fix/autocomplete-wrap-scroll-zindex
branch
from
ca43e53 to
2a18aa9
Compare
|
@topherfangio do you mind assign it to you? |
| }, false, $scope); | ||
| } | ||
| } else if (hidden && !oldHidden) { | ||
| $mdUtil.nextTick(function () { | ||
| $mdUtil.enableScrolling(); | ||
| if (revertWrapScrollBlocking) revertWrapScrollBlocking(); |
There was a problem hiding this comment.
Shouldn't this also set revertWrapScrollBlocking to null so it doesn't potentially try to do it twice?
There was a problem hiding this comment.
I don't think that's necessary, because the off events are bound to an unique event function, but I will update it, because it seems to be logical.
devversion
force-pushed
the
fix/autocomplete-wrap-scroll-zindex
branch
from
2a18aa9 to
f7e8ba2
Compare
topherfangio
added
needs: rebase
|
LGTM if it can be rebased :-) |
At the moment we set the z-index of the `autocomplete-wrap` to `51`, that's why it is usable while an open scrollmask So we only need to disable the scroll events to prevent scrolling when hovering over the `autocomplete-wrap` Fixes angular#6585. Fixes angular#5230. Fixes angular#5890.
devversion
force-pushed
the
fix/autocomplete-wrap-scroll-zindex
branch
from
f7e8ba2 to
5745e38
Compare
devversion
removed
the
needs: rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we set the z-index of the
autocomplete-wrapto51, that's why it is usable while an open scrollmaskSo we only need to disable the scroll events to prevent scrolling when hovering over the
autocomplete-wrapFixes #6585 Fixes #5230 Fixes #5890 Fixes #6716