This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(switch): fix switch drag functionality. #6715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/switch-drag-functionality
branch
from
f05cee5 to
b8d8cfc
Compare
| @@ -150,7 +150,7 @@ function MdCheckboxDirective(inputDirective, $mdAria, $mdConstant, $mdTheming, $ | |||
| } | |||
| } | |||
| function listener(ev) { | |||
| if (element[0].hasAttribute('disabled')) { | |||
| if (element[0].hasAttribute('disabled') || scope.skipToggle) { | |||
There was a problem hiding this comment.
@EladBezalel Should I add a comment here to explain what skipToggle is used for?
This was referenced Jan 22, 2016
devversion
force-pushed
the
fix/switch-drag-functionality
branch
from
b8d8cfc to
08ad0b2
Compare
EladBezalel
added
the
needs: manual testing
| var checkbox = compileAndLink('<md-checkbox ng-model="blue"></md-checkbox>'); | ||
| var scope = checkbox.scope(); | ||
|
|
||
| scope.skipToggle = true; |
There was a problem hiding this comment.
Why would this be set to 'true' ?
There was a problem hiding this comment.
Just to test if the checkbox skips the click, this is needed for the switch. Bust just rethought, it would make more sense to add this to the switch tests, using the switch extending the checkbox.
ThomasBurleson
added
needs: work
in progress
This fixes the complete switch drag functionality. Fix ported from my previous work at material2 (https://github.com/angular/material2/pull/7/files) Fixes angular#4719 Fixes angular#2338
devversion
force-pushed
the
fix/switch-drag-functionality
branch
from
08ad0b2 to
1036d6f
Compare
devversion
removed
in progress
ThomasBurleson
added
the
needs: team discussion
devversion
added
needs: review
ThomasBurleson
added
needs: work
in progress
|
@ThomasBurleson It's very hard for me to detect your reason.. What particular line or block needs work? |
|
@devversion - your conversation with @EladBezalel indicates unresolved agreement on solution. |
|
@ThomasBurleson I agree, thx. @EladBezalel Can you respond to my last comment? You didn't answer yet. |
|
@ThomasBurleson feels odd to me that we need to use |
EladBezalel
added
needs: review
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the complete switch drag functionality.
Fix ported from my previous work at material2 (https://github.com/angular/material2/pull/7/files)
Fixes #4719 Fixes #2338