This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(slider): clamp md-slider's initialisation #6858
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a model was set with a value outside of the `min` or the `max` of the slider, it would call `setSliderPercent` with the initial value and no check would occur to make sure that the value of the model could not extend the range of the slider. The below screenshot demonstrates what the slider looks like when it has been initialised with a value of `-1`.  As you can see, the thumb is floating way off to the left. This is due to the `left: -25%` style that has been applied to the element. It is worth noting that the `min` and `max` are `0` and `4` respectively.
|
lgtm. |
ThomasBurleson
added
the
pr: merge ready
ThomasBurleson
changed the title
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
Previously when a model was set with a value outside of the `min` or the `max` of the slider, it would call `setSliderPercent` with the initial value and no check would occur to make sure that the value of the model could not extend the range of the slider. The below screenshot demonstrates what the slider looks like when it has been initialised with a value of `-1`.  As you can see, the thumb is floating way off to the left. This is due to the `left: -25%` style that has been applied to the element. It is worth noting that the `min` and `max` are `0` and `4` respectively. Closes angular#6858
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a model was set with a value outside of the
minorthe
maxof the slider, it would callsetSliderPercentwith theinitial value and no check would occur to make sure that the value of
the model could not extend the range of the slider.
The below screenshot demonstrates what the slider looks like when it has
been initialised with a value of
-1.As you can see, the thumb is floating way off to the left. This is due
to the
left: -25%style that has been applied to the element. It isworth noting that the
minandmaxare0and4respectively.