This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(autocomplete): allow select on match to be case insensitive. #6935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
feat/autocomplete-match-insensitive
branch
from
265fb7d to
e2587f7
Compare
| if (searchText == displayValue) select(0); | ||
| var isMatching = searchText == displayValue; | ||
| if ($scope.matchInsensitive && !isMatching) { | ||
| isMatching = searchText.toLowerCase() == displayValue.toLowerCase(); |
There was a problem hiding this comment.
Not using a ternary operator here, because it will be really unclear.
isMatching == false is just saving up an unnecessary step.
| placeholder: '@placeholder', | ||
| noCache: '=?mdNoCache', | ||
| selectOnMatch: '=?mdSelectOnMatch', | ||
| matchInsensitive: '=?mdMatchCaseInsensitive', |
There was a problem hiding this comment.
Let's invert the logic here. Better name is matchCase which should have default value == false.
There was a problem hiding this comment.
@ThomasBurleson If understood everything right ->
- By default it will ignore case
- Allows caring about case when using
md-match-case="true"
Updated it to behave as this. See specs for example.
ThomasBurleson
added
in progress
devversion
force-pushed
the
feat/autocomplete-match-insensitive
branch
2 times, most recently
from
3476db5 to
659a4e6
Compare
devversion
force-pushed
the
feat/autocomplete-match-insensitive
branch
from
9607e4e to
a9286de
Compare
|
@ThomasBurleson is that by intention, that you merged the old version? without the change |
|
Would be great if you give a small statement to this 👍 |
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
|
CodePen? I can't get this too work. |
|
@gigablox Just apply the new attribute |
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5782