feat(autocomplete): support readonly attribute #7107
Conversation
| @@ -166,6 +167,7 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming, | |||
| var wait = parseInt($scope.delay, 10) || 0; | |||
| $attrs.$observe('disabled', function (value) { ctrl.isDisabled = !!value; }); | |||
| $attrs.$observe('required', function (value) { ctrl.isRequired = !!value; }); | |||
| $attrs.$observe('readonly', function (value) { ctrl.isReadonly = !!value; }); | |||
There was a problem hiding this comment.
This attribute needs to be fixed too (hopefully using the util method of #6803). Currently an empty readonly won't work...
There was a problem hiding this comment.
Could we use ctrl.isReadonly = value !== null for now? I think that should work.
There was a problem hiding this comment.
@robertmesserle Done - re-enabled test. I will rebase #6803 if this PR is merged.
There was a problem hiding this comment.
Yea, once #6803 gets merged, these will all use your utility function, right?
There was a problem hiding this comment.
Yes, then the attributes will also work with an empty attribute value. And a little side-effect will be, that required="false" also works. This won't break any existing versions, because it just adds false and 0 as a negative value.
devversion
force-pushed
the
feat/autocomplete-readonly
branch
2 times, most recently
from
b5f1357
to
7d11647
Compare
|
@devversion - please rebase with |
ThomasBurleson
added
needs: rebase
devversion
force-pushed
the
feat/autocomplete-readonly
branch
from
7d11647
to
bf1a6ce
Compare
devversion
added
pr: merge ready
devversion
force-pushed
the
feat/autocomplete-readonly
branch
from
bf1a6ce
to
92af63e
Compare
@robertmesserle Please review :)
Fixes #5507