fix(input): ngMessages height changing. #7146
Conversation
|
@EladBezalel Can you please review my changes when you get a moment? Everything looks good in the icons demo, but I wanted to double-check with you. |
topherfangio
added
needs: work
and removed
needs: review
|
@EladBezalel NVM...just noticed an alignment issue with the icons that I didn't see before :/ |
topherfangio
added
needs: review
| @@ -65,7 +65,15 @@ angular.module('material.components.input', [ | |||
| */ | |||
| function mdInputContainerDirective($mdTheming, $parse) { | |||
|
|
|||
| var INPUT_TAGS = ['INPUT', 'TEXTAREA', 'MD-SELECT']; | |||
| var INPUT_TAGS = ['INPUT', 'TEXTAREA', 'SELECT', 'MD-SELECT']; | |||
There was a problem hiding this comment.
Shouldn't this be in a const?
|
Nice improvement @topherfangio LGTM. |
EladBezalel
added
the
needs: manual testing
When using `ng-messages` inside of an input container, the height of the messages will change when appearing, which pushes other elements out of the way. This was a regression from the previous behavior which allowed space for a one-line message before pushing other content out of the way. This was caused by some changes to the icons inside of an input. Fix by finding an alternate method to address the icon issue. Fixes angular#7072.
topherfangio
force-pushed
the
fix-input-icons-7072
branch
from
2fbb63c to
5619939
Compare
EladBezalel
removed
the
needs: manual testing
|
|
||
| var LEFT_SELECTORS = INPUT_TAGS.reduce(function(selectors, isel) { | ||
| return selectors.concat(['md-icon ~ ' + isel, '.md-icon ~ ' + isel]); | ||
| }, []).join(","); |
There was a problem hiding this comment.
You can use .toString() instead of .join(',') they're equivalent on arrays
|
@EladBezalel Just wanted to touch base, is this ready for merge, or does it still need manual testing? :-) |
|
i've tested it manually and it's working good, what about the |
|
@EladBezalel I never knew that |
EladBezalel
added
pr: merge ready
|
BTW |
|
@topherfangio - 👍 |
When using
ng-messagesinside of an input container, the heightof the messages will change when appearing, which pushes other
elements out of the way. This was a regression from the previous
behavior which allowed space for a one-line message before pushing
other content out of the way.
This was caused by some changes to the icons inside of an input.
Fix by finding an alternate method to address the icon issue.
Fixes #7072.