This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(theming): theming should also watch for controller changes. #7154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the dialog inherits the controllers not at link time, the theming won't work. Tried a few possibilities: - Walking through the DOM after show and re-theme the elements - Recompile the template after show But the most elegant and performant solution is definitely watching for the controller change. Fixes angular#5899
This was referenced Feb 19, 2016
|
@devversion - please check if this demo still works with your changes: http://codepen.io/team/AngularMaterial/pen/NxZZjY (see Login dialog with custom theme) |
|
@ThomasBurleson Yes work's still perfect. |
ThomasBurleson
added
pr: merge ready
ThomasBurleson
pushed a commit
that referenced
this pull request
Mar 16, 2016
As the dialog inherits the controllers not at link time, the theming won't work. Tried a few possibilities: - Walking through the DOM after show and re-theme the elements - Recompile the template after show But the most elegant and performant solution is definitely watching for the controller change. Fixes #5899 Closes #7154
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
As the dialog inherits the controllers not at link time, the theming won't work. Tried a few possibilities: - Walking through the DOM after show and re-theme the elements - Recompile the template after show But the most elegant and performant solution is definitely watching for the controller change. Fixes #5899 Closes #7154
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
As the dialog inherits the controllers not at link time, the theming won't work. Tried a few possibilities: - Walking through the DOM after show and re-theme the elements - Recompile the template after show But the most elegant and performant solution is definitely watching for the controller change. Fixes #5899 Closes #7154
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the dialog inherits the controllers not at link time, the theming won't work.
Tried a few possibilities:
But the most elegant and performant solution is definitely watching for the controller change.
Fixes #5899