This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(icon): disable e11 focus for SVG icons #7321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently IE11 always sets the SVG icons focusable. This can be reproduced by tabbing through the `Getting Started` section of the docs. There will be always two tab-steps when iterating through the icon button in IE11. Fixes angular#7250
devversion
force-pushed
the
fix/ie11-icon-focus
branch
from
5634d4f to
bff0a1b
Compare
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently IE11 always sets the SVG icons focusable.
This can be reproduced by tabbing through the
Getting Startedsection of the docs.There will be always two tab-steps when iterating through the icon button in IE11.
@programmist Can you take a look?
Fixes #7250