-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: Layout issue with flex and layout breakpoints #6528 #7327
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@@ -135,7 +135,23 @@ | |||
box-sizing: border-box; | |||
} | |||
|
|||
.layout-row > .#{$flexName}-#{$i * 5}, | |||
.layout-row > .#{$flexName}-#{$i * 5} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work in you have markup like this:
<div layout="row" layout-sm="column">
<div flex="33" flex-sm="95">
<div flex="33" flex-sm="95">
<div flex="33" flex-sm="95">
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad! Kind of never user 33 and 66. FIxed it up.
Change class definition order in flex-properties-for-name mixin. Closes angular#6528
Sorry, my bad! Kind of never user 33 and 66. FIxed it up. |
@keenondrums - why did you change the class definition order in flex-properties-for-name mixin. |
@ThomasBurleson, maybe my mind is not at the right place but that was kind of the whole issue behind the bug described in the related issue #6528. Please correct me if I'm wrong. I'd be happy to answer any questions via Skype if that's more convenient for you. My skype id is keenondrums. |
fix: Layout issue with flex and layout breakpoints
Change class definition order in flex-properties-for-name mixin.
Closes #6528