Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

aigoncharov
Copy link
Contributor

fix: Layout issue with flex and layout breakpoints

Change class definition order in flex-properties-for-name mixin.

Closes #6528

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@aigoncharov
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@ThomasBurleson ThomasBurleson added - Breaking Change needs: review This PR is waiting on review from the team labels Feb 29, 2016
@ThomasBurleson ThomasBurleson added this to the 1.1.0 milestone Feb 29, 2016
@ThomasBurleson ThomasBurleson self-assigned this Feb 29, 2016
@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for a caretaker to review needs: review This PR is waiting on review from the team and removed needs: review This PR is waiting on review from the team pr: merge ready This PR is ready for a caretaker to review labels Mar 2, 2016
@@ -135,7 +135,23 @@
box-sizing: border-box;
}

.layout-row > .#{$flexName}-#{$i * 5},
.layout-row > .#{$flexName}-#{$i * 5} {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work in you have markup like this:

<div layout="row" layout-sm="column">
  <div flex="33"  flex-sm="95">
  <div flex="33"  flex-sm="95">
  <div flex="33"  flex-sm="95">
</div>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad! Kind of never user 33 and 66. FIxed it up.

Change class definition order in flex-properties-for-name mixin.

Closes angular#6528
@aigoncharov
Copy link
Contributor Author

Sorry, my bad! Kind of never user 33 and 66. FIxed it up.

@ThomasBurleson ThomasBurleson removed the needs: review This PR is waiting on review from the team label Apr 19, 2016
@ThomasBurleson
Copy link
Contributor

@keenondrums - why did you change the class definition order in flex-properties-for-name mixin.

@ThomasBurleson ThomasBurleson modified the milestones: 1.1.1, 1.1.0 Apr 19, 2016
@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Apr 19, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.1, Backlog Apr 21, 2016
@aigoncharov
Copy link
Contributor Author

@ThomasBurleson, maybe my mind is not at the right place but that was kind of the whole issue behind the bug described in the related issue #6528. Please correct me if I'm wrong. I'd be happy to answer any questions via Skype if that's more convenient for you. My skype id is keenondrums.

@Splaktar Splaktar removed this from the - Backlog milestone Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout issue with flex and layout breakpoints
4 participants