This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(slider-rtl): added rtl support for slider #7434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EladBezalel
commented
Mar 6, 2016
EladBezalel
commented
- added bidi-property function to set a property by direction
- fixed slider in rtl
EladBezalel
added
i18n: bi-directional
| @@ -549,6 +555,10 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi | |||
| var size = vertical ? sliderDimensions.height : sliderDimensions.width; | |||
| var calc = (position - offset) / size; | |||
|
|
|||
| if (!vertical && $mdUtil.bidi() === 'rtl') { | |||
There was a problem hiding this comment.
Since when is $mdUtil.bidi() returning a value?
|
@EladBezalel this does not work properly!
|
|
@EladBezalel - what is the status of this PR ? |
ThomasBurleson
added
in progress
|
@EladBezalel - please rebase and confirm PR is valid. |
|
@EladBezalel - ping |
|
@ThomasBurleson working on it |
EladBezalel
force-pushed
the
fix/slider-rtl
branch
from
251b8c6 to
dadbf8f
Compare
EladBezalel
added
needs: review
EladBezalel
force-pushed
the
fix/slider-rtl
branch
from
dadbf8f to
977324a
Compare
|
@EladBezalel - status ping ? |
- added bidi-property function to set a property by direction - fixed slider in rtl
EladBezalel
force-pushed
the
fix/slider-rtl
branch
from
977324a to
586c704
Compare
|
@ThomasBurleson this is ready IMO |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.