This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(icon): rename nodes id's from cache to prevent duplicates. #7468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@topherfangio please take a look as well |
|
Hi @devversion , The fix looks cool 👍 |
|
@EladBezalel LGTM 👍 |
EladBezalel
added
pr: merge ready
devversion
added
the
needs: rebase
Currently we always rename the icons id's on cache initialization, but that causes problems, when using the cached icon multiple times in the app. A super elegant solution, is to transform the ids, when the icon is requested from the cache.
devversion
force-pushed
the
fix/icon-duplicate-ids
branch
from
df6f94f to
c74dfda
Compare
devversion
removed
the
needs: rebase
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
Currently we always rename the icons id's on cache initialization, but that causes problems, when using the cached icon multiple times in the app. A super elegant solution, is to transform the ids, when the icon is requested from the cache. Closes #7468
ThomasBurleson
pushed a commit
that referenced
this pull request
Apr 1, 2016
Currently we always rename the icons id's on cache initialization, but that causes problems, when using the cached icon multiple times in the app. A super elegant solution, is to transform the ids, when the icon is requested from the cache. Closes #7468
gmoothart
pushed a commit
to gmoothart/material
that referenced
this pull request
Apr 5, 2016
Currently we always rename the icons id's on cache initialization, but that causes problems, when using the cached icon multiple times in the app. A super elegant solution, is to transform the ids, when the icon is requested from the cache. Closes angular#7468
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always rename the icons id's on cache initialization, but that causes problems, when using the cached icon multiple times in the app.
A super elegant solution, is to transform the ids, when the icon is requested from the cache.
Referencing #7467
@david-gang Ping.