This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): spinner size #7506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the new changes in the `progressCircular` component, the spinner was being rendered bigger than usual. This change reverts to the old size. Fixes angular#7505
| @@ -144,7 +144,7 @@ function SelectDirective($mdSelect, $mdUtil, $mdTheming, $mdAria, $compile, $par | |||
| .find('md-content') | |||
| .prepend(angular.element( | |||
| '<div>' + | |||
| ' <md-progress-circular md-mode="{{progressMode}}" ng-hide="$$loadingAsyncDone"></md-progress-circular>' + | |||
| ' <md-progress-circular md-mode="{{progressMode}}" ng-hide="$$loadingAsyncDone" md-diameter="25px"></md-progress-circular>' + | |||
There was a problem hiding this comment.
Shouldn't that be md-diameter="25"?
I know it will still work with the px suffix because the float will be parsed and ignores the text.
There was a problem hiding this comment.
I wanted it to be as obvious as possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the new changes in the
progressCircularcomponent,the spinner was being rendered bigger than usual. This change
reverts to the old size.
Fixes #7505