Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Add @ngInject to core.js files. #7608

Closed
wants to merge 1 commit into from
Closed

Add @ngInject to core.js files. #7608

wants to merge 1 commit into from

Conversation

mhansen
Copy link
Contributor

@mhansen mhansen commented Mar 17, 2016

Otherwise the closure compiler's renaming will break the injection.

@mhansen
Add @ngInject to core.js files.
4f16bc2 
Otherwise the closure compiler's renaming will break the injection.
@mhansen
Copy link
Contributor Author

mhansen commented Mar 17, 2016

#7610

@crisbeto crisbeto added the pr: merge ready This PR is ready for a caretaker to review label Mar 17, 2016
@crisbeto
Copy link
Member

LGTM 👍

ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
@mhansen @ThomasBurleson
fix(build): closure build needs @ngInject to $mdUtil
284c861 
Without this, closure compiler renaming breaks injection.

*  also needs @ngInject to $mdMedia
*  also needs @ngInject to core.js files.

Closes #7611. Closes #7609. Closes #7608.
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
@mhansen @ThomasBurleson
fix(build): closure build needs @ngInject to $mdUtil
d3c29fe 
Without this, closure compiler renaming breaks injection.

*  also needs @ngInject to $mdMedia
*  also needs @ngInject to core.js files.

Closes #7611. Closes #7609. Closes #7608.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhansen @crisbeto