This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(button): reduce selector length #7705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `a.md-button.md-THEME_NAME-theme` in the button theme didn't really do anything, however because there's quite a lot of nesting going on, it almost doubled the amount of selectors.
|
LGTM |
crisbeto
added
pr: merge ready
gmoothart
pushed a commit
to gmoothart/material
that referenced
this pull request
Apr 5, 2016
The `a.md-button.md-THEME_NAME-theme` in the button theme didn't really do anything, however because there's quite a lot of nesting going on, it almost doubled the amount of selectors. Closes angular#7705
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
a.md-button.md-THEME_NAME-themein the button theme didn't really do anything, howeverbecause there's quite a lot of nesting going on, it almost doubled the amount of selectors.
This was introduced in 0178b89.